-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "ryu" library to format floats in text form. #8542
Conversation
Performance test is Ok and shows 2% improvement across all the test cases: One query was slowed down, need further investigation:
|
Yes,
Update. Actually, it's not only because of this function. |
Now we have 4% overall performance increase: And there is no slower queries. |
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Improved performance of formatting floating point numbers up to 6 times.
Detailed description (optional):
This PR is opened only to be closed. Because in contrast to
double-conversion
, theryu
library doesn't have the mode to prefer simple format over exponential:That's non satisfactory. Probably we can add support for this formatting mode if performance benefits will look as a viable tradeoff.
Update 1: it still has a chance.
Update 2: after some work, it's ready to be integrated.