Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add array function auc #8698

Merged
merged 11 commits into from
Mar 24, 2020
Merged

Conversation

taiyang-li
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):

@taiyang-li
Copy link
Contributor Author

The Two failed integration tests seem not caused by my commit.

@qoega qoega added the doc-alert label Feb 6, 2020
docs/en/query_language/functions/array_functions.md Outdated Show resolved Hide resolved
dbms/tests/queries/0_stateless/01064_array_auc.sql Outdated Show resolved Hide resolved
dbms/src/Functions/array/arrayScalarProduct.h Outdated Show resolved Hide resolved
dbms/src/Functions/array/arrayScalarProduct.h Outdated Show resolved Hide resolved
docs/en/query_language/functions/array_functions.md Outdated Show resolved Hide resolved
dbms/src/Functions/array/array_auc.cpp Outdated Show resolved Hide resolved
docs/en/query_language/functions/array_functions.md Outdated Show resolved Hide resolved
dbms/src/Functions/array/array_auc.cpp Outdated Show resolved Hide resolved
@alexey-milovidov
Copy link
Member

@taiyang-li I did not understand the code in the inner loop.
I tried to imagine the algorithm and have rewrite it to something more simple:
27f0b93

I'm not sure that it's 100% correct (I'm not into machine learning) but your tests have passed.

@alexey-milovidov alexey-milovidov merged commit 256aceb into ClickHouse:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants