Shard now clamps the settings from the initiator. #9447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitlibar
changed the title
|
Integration tests are to be updated? |
…onstaints instead of throwing an exception.
vitlibar
force-pushed
the
shard-clamps-settings-to-constraints
branch
from
45dcdb9
to
fc0376a
Compare
KochetovNicolai
added
pr-bugfix
vitlibar
added a commit
that referenced
this pull request
Mar 27, 2020
…raints Shard now clamps the settings from the initiator. (cherry picked from commit 5b4b40f)
vitlibar
pushed a commit
that referenced
this pull request
Apr 14, 2020
…raints Shard now clamps the settings from the initiator. (cherry picked from commit 5b4b40f)
|
We have to add good documentation about this behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
Shard now clamps the settings got from the initiator to the shard's constaints instead of throwing an exception. This fix allows to send queries to a shard with another constraints.