You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I took a stab at making a PR to support the 610 API version, but it will require either a) breaking backward compatibility or b) wrapping code with #[cfg(feature = "fdb-6_1")] blocks all over the place.
Since it's a bit messy, I figured I'd start a discussion first before moving forward. What do people think the best way to move forward is? My preference is to prevent breaking backward compatibility at the expense of introducing some more complexity.
In the meantime, I have a small patch here that uses the 600 API version with the 6.1.x client libraries: brndnmtthws@ee95ad4
The text was updated successfully, but these errors were encountered:
If it's simple enough to do, the #[cfg(feature = "fdb-6_1")] would be the best option for backward compatibility, though we probably want to make it forward compatible, so that anything after 6_1 gets the changes as well. Then the fdb-6_1 feature would depend on post-fdb-6_1 feature (as would all future fdb versions...)
There might be some elegant ways of doing this with traits and feature gated modules for those implementations?
FDB 6.1.8 is the current stable release, and the 6.1 API has some backward incompatible changes. Here are the details on the changes:
I took a stab at making a PR to support the
610
API version, but it will require either a) breaking backward compatibility or b) wrapping code with#[cfg(feature = "fdb-6_1")]
blocks all over the place.Since it's a bit messy, I figured I'd start a discussion first before moving forward. What do people think the best way to move forward is? My preference is to prevent breaking backward compatibility at the expense of introducing some more complexity.
In the meantime, I have a small patch here that uses the
600
API version with the 6.1.x client libraries: brndnmtthws@ee95ad4The text was updated successfully, but these errors were encountered: