Async/await and FDB 6.1 support #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- build on nightly until rust 1.39 arrives - switch to 6.1 API and create database directly - drop support for Cluster and FDB releases prior to 6.1, as the async changes are a breaking change anyway - updated db.transact to retry failures in body, as in #125 - made should_retry() on error objects public - changed some sync functions that were using .wait() to async (eg HCA allocate)
When fdb_future_destroy() is called on a future that hasn't resolved, it causes the callback to fire. If it fires after the box the waker/task was held in has already been deallocated, it can result in a crash. Fix the issue by dropping the allocation in the callback instead. This issue also exists in the stable foundationdb-rs release.
This reverts commit 371c34d. While rust-toolchain remains in the repo, stable and beta tests seem to run on nightly as well, so we should be able to leave the tests there and they'll automatically start running on beta/stable again when rust-toolchain is removed after the rust 1.39 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #135
Closes #135 #136 #125 #124 and #111