Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Romanian translation #541

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

mateesville93
Copy link
Contributor

No description provided.

@mateesville93
Copy link
Contributor Author

Do you have in plan to support Pluralization like Hugo?(Some languages need this):
Example for reading time of a post below:
English:
[reading_time]
one = "One minute to read"
other = "{{ .Count }} minutes to read"

Romanian:
[reading_time]
one = "Un minut de citit"
few = "{{ .Count }} minute de citit"
other = "{{ .Count }} de minute de citit"

@bglw
Copy link
Contributor

bglw commented Jan 14, 2024

Currently Pagefind switches between the zero_results / many_results / one_result translation strings for 0 / 1 / 2+ results.

This won't handle languages with other forms of pluralization, e.g. few vs many — if you have specific rules that would help you here we could add something like a few_results string that can handle a specific number range — let me know what you need :)

@mateesville93
Copy link
Contributor Author

mateesville93 commented Jan 15, 2024

Will be nice to have something like this: zero_results / one_results / two_results / few_results / other_results
Here is a reference for ranges:
https://www.unicode.org/cldr/charts/44/supplemental/language_plural_rules.html#ro
Accordingly to Unicode.org: "Languages vary in how they handle plurals of nouns or unit expressions ("hours", "meters", and so on). Some languages have two forms, like English; some languages have only a single form; and some languages have multiple forms (see Slovenian below)."

@mateesville93
Copy link
Contributor Author

Someone to merge this PR?

@bglw
Copy link
Contributor

bglw commented Mar 26, 2024

Hey @mateesville93 , sorry for the delay! Merging now, and I'll ping you again when the next release lands.

@bglw bglw merged commit d912d51 into CloudCannon:main Mar 26, 2024
1 check passed
@bglw
Copy link
Contributor

bglw commented Apr 2, 2024

Released in released in v1.1.0, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants