Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLOC-4447] Add google-compute-engine as a requirement #2833

Merged
merged 3 commits into from
Jun 24, 2016

Conversation

wallrj
Copy link
Contributor

@wallrj wallrj commented Jun 16, 2016

Fixes: https://clusterhq.atlassian.net/browse/FLOC-4447

This is caused by:

I've added google-compute-engine package here but in re-running the admin/update-requirements tool I've pulled in a few other library upgrades and a new version of setuptools.
All good stuff I'm sure and all the tests still pass.

I had some trouble with the GCE functional tests:

But that turned out be the fault of the old version of virtualenv installed on our static GCE slaves.

I manually upgraded pip and virtualenv as the jenkins user on those slaves.

We should really update the VM images too, but this works for now.
(as discussed with @sarum90 a week or two ago)

@myechuri
Copy link
Contributor

@wallrj : can you please confirm that all the other (non google-compute-engine) package version updates are unrelated? Thanks!

Accepted the issue, please go ahead with the merge, thanks for making the changes!

@wallrj
Copy link
Contributor Author

wallrj commented Jun 24, 2016

Thanks @myechuri for the review.

@wallrj : can you please confirm that all the other (non google-compute-engine) package version updates are unrelated?

Yep, the only change needed here is the addition of google-compute-engine but unfortunately the admin/update-requirements tool grabs the latest versions of all the libraries listed in the .in files.

I'm not happy with that and I'm sure that @exarkun and @moshez would frown on it, but on the other hand the updates are all minor or micro version changes, the tests all still pass and the idea behind the update-requirements tool was to keep everything up-to-date so that we can monitor our dependency versions with requires.io and respond to their warnings.....I haven't done that bit yet.

I could pin all those other requirements to their previous versions, but it doesn't seem worth it.

Merging.

@wallrj wallrj merged commit 5ebf2c1 into master Jun 24, 2016
@wallrj wallrj deleted the google-compute-engine-FLOC-4447 branch June 24, 2016 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants