Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for generating incremental streams when pushing volumes #657

Merged
merged 18 commits into from
Sep 5, 2014
Merged

Add support for generating incremental streams when pushing volumes #657

merged 18 commits into from
Sep 5, 2014

Commits on Sep 2, 2014

  1. An attempt at a functional test for the desired `IFilesystem.reader… 

    …` behavior.
    @exarkun
    exarkun committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    d77a7fb View commit details
    Browse the repository at this point in the history

  2. Use the service to create the volume. This should be more realistic.

    @exarkun
    exarkun committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    503c67f View commit details
    Browse the repository at this point in the history

  3. Add a functional test for the new Filesystem.snapshots method (nece… 

    …ssary for the other new functional test, as well as for other reasons).
    @exarkun
    exarkun committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    7fe0a7f View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2014

  1. Must construct Snapshots using keyword arguments.

    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    5441c8b View commit details
    Browse the repository at this point in the history

  2. Filesystem.snapshots returns a Deferred.

    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    12d9bb0 View commit details
    Browse the repository at this point in the history

  3. Execute the snapshot command correctly - with an identifier to assign… 

    … to the new snapshot.
    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    7476d79 View commit details
    Browse the repository at this point in the history

  4. Test listing the snapshots of the root dataset *and* non-root datasets.

    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    4194605 View commit details
    Browse the repository at this point in the history

  5. Factor some snapshot listing code out into a separate API for easier … 

    …re-use elsewhere. Also change the behavior slightly so that the results are sorted by creation time rather than name.

Previously we considered encoding the creation time in the snapshot name itself but we have not actually done this yet.
The creation property that zfs itself maintains lets us get snapshots in a useful order.
The incremental send code wants to use the most recent snapshot - so having them ordered by creation time helps.
    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    cb501bd View commit details
    Browse the repository at this point in the history

  6. docstring reformatting

    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    afe8b9c View commit details
    Browse the repository at this point in the history

  7. Construct an incremental send if there is a common snapshot on which … 

    …to base it.
    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    27a8a89 View commit details
    Browse the repository at this point in the history

  8. Add direct unit tests for _latest_common_snapshot and make it work ri… 

    …ght.
    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    f06b0db View commit details
    Browse the repository at this point in the history

  9. Documentation fixes for the modified reader interface.

    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    9492f61 View commit details
    Browse the repository at this point in the history

  10. Fix lint error

    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    1b7e8f4 View commit details
    Browse the repository at this point in the history

  11. Add snapshots to the interface and the in-memory implementation. 

    Also add a generic interface test for the extremely boring case - which
happens to be the only case the other implementation handles.
    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    a2824fd View commit details
    Browse the repository at this point in the history

  12. Make the in-memory filesystem snapshot listing return a Deferred as i… 

    …t should have before. Also fix the test to catch this.
    @exarkun
    exarkun committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    2f6bb83 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2014

  1. Reference a ticket about improving this.

    @exarkun
    exarkun committed Sep 5, 2014
    Configuration menu
    Copy the full SHA
    0be061a View commit details
    Browse the repository at this point in the history

  2. Avoid the weird thing using a bound special method.

    @exarkun
    exarkun committed Sep 5, 2014
    Configuration menu
    Copy the full SHA
    6706c2e View commit details
    Browse the repository at this point in the history

  3. some doc improvements

    @exarkun
    exarkun committed Sep 5, 2014
    Configuration menu
    Copy the full SHA
    66829b0 View commit details
    Browse the repository at this point in the history