chore: set MSRV to 1.74 and enforce it in CI

CodSpeedHQ · Sep 6, 2024 · 0cbca01 · 0cbca01
1 parent 6903770
commit 0cbca01
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 13 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,6 +18,20 @@ jobs:
         with:
           extra_args: --all-files
 
+  msrv-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: moonrepo/setup-rust@v1
+        with:
+          bins: cargo-msrv
+      - name: Check cospeed MSRV
+        run: cargo msrv --path crates/codspeed verify -- cargo check --all-features --config codspeed=true
+      - name: Check bencher_compat MSRV
+        run: cargo msrv --path crates/bencher_compat verify -- cargo check --all-features --config codspeed=true
+      - name: Check criterion_compat MSRV
+        run: cargo msrv --path crates/criterion_compat verify -- cargo check --all-features --config codspeed=true
+
   tests:
     runs-on: ubuntu-latest
     steps:

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/bencher_compat/Cargo.toml b/crates/bencher_compat/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "codspeed-bencher-compat"
 version = "2.7.0"
+rust-version = "1.74" # MSRV
 edition = "2021"
 description = "Bencher compatibility layer for CodSpeed"
 authors = ["Arthur Pastel <arthur@codspeed.io>"]

diff --git a/crates/bencher_compat/build.rs b/crates/bencher_compat/build.rs
@@ -1,3 +1,3 @@
 fn main() {
-    println!("cargo::rustc-check-cfg=cfg(codspeed)");
+    println!("cargo:rustc-check-cfg=cfg(codspeed)");
 }
diff --git a/crates/codspeed/Cargo.toml b/crates/codspeed/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "codspeed"
 version = "2.7.0"
+rust-version = "1.74" # MSRV
 edition = "2021"
 description = "Core instrumentation library for CodSpeed"
 authors = ["Arthur Pastel <arthur@codspeed.io>"]

diff --git a/crates/criterion_compat/Cargo.toml b/crates/criterion_compat/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "codspeed-criterion-compat"
 version = "2.7.0"
+rust-version = "1.74" # MSRV
 edition = "2021"
 description = "Criterion.rs compatibility layer for CodSpeed"
 authors = ["Arthur Pastel <arthur@codspeed.io>"]
@@ -20,7 +21,7 @@ criterion = { version = "0.5.1", default-features = false }
 codspeed = { path = "../codspeed", version = "=2.7.0" }
 colored = "2.1.0"
 
-futures = { version = "0.3", default_features = false, optional = true }
+futures = { version = "0.3", default-features = false, optional = true }
 smol = { version = "2.0", default-features = false, optional = true }
 tokio = { version = "1.39", default-features = false, features = [
   "rt",

diff --git a/crates/criterion_compat/build.rs b/crates/criterion_compat/build.rs
@@ -1,3 +1,3 @@
 fn main() {
-    println!("cargo::rustc-check-cfg=cfg(codspeed)");
+    println!("cargo:rustc-check-cfg=cfg(codspeed)");
 }