Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assert_equals instead of snapshots #77

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Use assert_equals instead of snapshots #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33df968
feat: upgrade bashunit 0.11
Chemaclass May 25, 2024
9ca879f
simplify using assert_equals instead of snapshots
Chemaclass May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash

## bashunit
curl -s https://bashunit.typeddevs.com/install.sh | bash -s -- lib 0.10.0
curl -s https://bashunit.typeddevs.com/install.sh | bash -s -- lib 0.11.0
12 changes: 6 additions & 6 deletions tests/github_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ ignore_file_deletions='false'
function test_should_count_changes() {
mock curl cat ./tests/fixtures/pull_request_api

assert_match_snapshot "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
assert_equals 174 "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
}

function test_should_count_changes_ignore_line_deletions() {
ignore_line_deletions='true'

mock curl cat ./tests/fixtures/pull_request_api

assert_match_snapshot "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
assert_equals 173 "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
}

# NOTE: when `files_to_ignore` or `ignore_file_deletions` is set, we have to invoke the PR files API and iterate each file
Expand All @@ -31,15 +31,15 @@ function test_should_count_changes_ignore_file_deletions() {

mock curl cat ./tests/fixtures/pull_request_files_api

assert_match_snapshot "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
assert_equals 2779 "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
}

function test_should_ignore_files_with_glob() {
files_to_ignore=("*.lock" ".editorconfig")

mock curl cat ./tests/fixtures/pull_request_files_api

assert_match_snapshot "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
assert_equals 517 "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
}

function test_should_ignore_files_with_glob_ignore_line_deletions() {
Expand All @@ -48,7 +48,7 @@ function test_should_ignore_files_with_glob_ignore_line_deletions() {

mock curl cat ./tests/fixtures/pull_request_files_api

assert_match_snapshot "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
assert_equals 224 "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
}

function test_should_ignore_files_with_glob_ignore_file_deletions() {
Expand All @@ -57,5 +57,5 @@ function test_should_ignore_files_with_glob_ignore_file_deletions() {

mock curl cat ./tests/fixtures/pull_request_files_api

assert_match_snapshot "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
assert_equals 394 "$(github::calculate_total_modifications "$pr_number" "${files_to_ignore[*]}" "$ignore_line_deletions" "$ignore_file_deletions")"
}
1 change: 0 additions & 1 deletion tests/snapshots/github_test_sh.test_should_count_changes.snapshot
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/snapshots/github_test_sh.test_should_count_changes_ignore_file_deletions.snapshot
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/snapshots/github_test_sh.test_should_count_changes_ignore_line_deletions.snapshot
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/snapshots/github_test_sh.test_should_ignore_files_with_glob.snapshot
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...napshots/github_test_sh.test_should_ignore_files_with_glob_ignore_file_deletions.snapshot
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...napshots/github_test_sh.test_should_ignore_files_with_glob_ignore_line_deletions.snapshot
View file
Open in desktop

This file was deleted.

Loading