Fix - merging multiple documents with and without headers and footers

Codeuctivity · Jul 6, 2023 · 8501bf6 · 8501bf6
2 parents 9cb0b61 + 56d0d4a
commit 8501bf6
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
@@ -18,7 +18,7 @@ jobs:
       pull-requests: write
 
     steps:
-    - uses: actions/stale@v7
+    - uses: actions/stale@v8
       with:
         repo-token: ${{ secrets.GITHUB_TOKEN }}
         stale-issue-message: 'Stale issue message'

diff --git a/OpenXmlPowerTools.Tests/DocumentBuilderTests.cs b/OpenXmlPowerTools.Tests/DocumentBuilderTests.cs
@@ -595,6 +595,23 @@ public void DB0016_DocDefaultStyles()
             Assert.Single(styles);
         }
 
+        [Fact]
+        public void DB017_ApplyHeaderAndFooterToAllDocs()
+        {
+            var sourceDir = new DirectoryInfo("../../../../TestFiles/");
+            var source1 = new FileInfo(Path.Combine(sourceDir.FullName, "DB017-ApplyHeaderAndFooterToAllDocs-Portrait-TwoColumns.docx"));
+            var source2 = new FileInfo(Path.Combine(sourceDir.FullName, "DB017-ApplyHeaderAndFooterToAllDocs-Landscape-SingleColumn.docx"));
+
+            var sources = new List<Source>()
+            {
+                new Source(new WmlDocument(source1.FullName)){KeepSections = true},
+                new Source(new WmlDocument(source2.FullName)){KeepSections = true, DiscardHeadersAndFootersInKeptSections = true},
+            };
+
+            var processedDestDocx = new FileInfo(Path.Combine(Path.Combine(TestUtil.TempDir.FullName), "DB017-ApplyHeaderAndFooterToAllDocs.docx"));
+            DocumentBuilder.BuildDocument(sources, processedDestDocx.FullName);
+        }
+
         [Theory]
         [InlineData("DB100-00010", "DB/GlossaryDocuments/CellLevelContentControl-built.docx", "DB/GlossaryDocuments/BaseDocument.docx,0,4", "DB/GlossaryDocuments/CellLevelContentControl.docx", "DB/GlossaryDocuments/BaseDocument.docx,4", null, null, null)]
         [InlineData("DB100-00020", "DB/GlossaryDocuments/InlineContentControl-built.docx", "DB/GlossaryDocuments/BaseDocument.docx,0,4", "DB/GlossaryDocuments/InlineContentControl.docx", "DB/GlossaryDocuments/BaseDocument.docx,4", null, null, null)]

diff --git a/OpenXmlPowerTools/DocumentBuilder/DocumentBuilder.cs b/OpenXmlPowerTools/DocumentBuilder/DocumentBuilder.cs
@@ -1169,8 +1169,11 @@ private static void CopyOrCacheHeaderOrFooter(WordprocessingDocument doc, Cached
             var referenceElement = FindReference(sect, referenceXName, type);
             if (referenceElement == null)
             {
-                var cachedPartRid = cachedHeaderFooter.FirstOrDefault(z => z.Ref == referenceXName && z.Type == type).CachedPartRid;
-                AddReferenceToExistingHeaderOrFooter(sect, cachedPartRid, referenceXName, type);
+                var cachedPartRid = cachedHeaderFooter.FirstOrDefault(z => z.Ref == referenceXName && z.Type == type)?.CachedPartRid;
+                if (cachedPartRid != null)
+                {
+                    AddReferenceToExistingHeaderOrFooter(sect, cachedPartRid, referenceXName, type);
+                }
             }
             else
             {

diff --git a/TestFiles/DB017-ApplyHeaderAndFooterToAllDocs-Landscape-SingleColumn.docx b/TestFiles/DB017-ApplyHeaderAndFooterToAllDocs-Landscape-SingleColumn.docx
diff --git a/TestFiles/DB017-ApplyHeaderAndFooterToAllDocs-Portrait-TwoColumns.docx b/TestFiles/DB017-ApplyHeaderAndFooterToAllDocs-Portrait-TwoColumns.docx