Merge pull request #69 from Codeuctivity/PuppeteerSharpBreakingChange… #256
Annotations
14 warnings
Codeuctivity.HtmlRendererCli/Program.cs#L43
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRendererCli/Program.cs#L43
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRendererCli/Program.cs#L44
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRendererCli/Program.cs#L20
Method 'Task<int> Program.Main(string[] args)' passes a literal string as parameter 'value' of a call to 'void Console.WriteLine(string? value)'. Retrieve the following string(s) from a resource table instead: "Usage: PuppeteerSharp.RendererCli <sourceHtmlFilePath> <destinatioPdfFilePath>". (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1303)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L64
Use recommended dispose pattern to ensure that object created by 'new BrowserFetcher()' is disposed on all paths. If possible, wrap the creation within a 'using' statement or a 'using' declaration. Otherwise, use a try-finally pattern, with a dedicated local variable declared before the try region and an unconditional Dispose invocation on non-null value in the 'finally' region, say 'x?.Dispose()'. If the object is explicitly disposed within the try region or the dispose ownership is transfered to another object or method, assign 'null' to the local variable just after such an operation to prevent double dispose in 'finally'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L96
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L97
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L171
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L202
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L225
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L64
Use recommended dispose pattern to ensure that object created by 'new BrowserFetcher()' is disposed on all paths. If possible, wrap the creation within a 'using' statement or a 'using' declaration. Otherwise, use a try-finally pattern, with a dedicated local variable declared before the try region and an unconditional Dispose invocation on non-null value in the 'finally' region, say 'x?.Dispose()'. If the object is explicitly disposed within the try region or the dispose ownership is transfered to another object or method, assign 'null' to the local variable just after such an operation to prevent double dispose in 'finally'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L129
Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L96
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Codeuctivity.HtmlRenderer/Renderer.cs#L97
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
The logs for this run have expired and are no longer available.
Loading