Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge 73 - Acrostic #1671

Merged
merged 9 commits into from
Sep 2, 2024
Merged

Challenge 73 - Acrostic #1671

merged 9 commits into from
Sep 2, 2024

Conversation

fturmel
Copy link
Collaborator

@fturmel fturmel commented Jul 20, 2024

Related #1627

https://deploy-preview-1671--codingtrain.netlify.app/challenges/73-acrostic

Created chapters for the video and migrated content from
https://github.com/CodingTrain/website-archive/blob/main/_CodingChallenges/073-acrostic.md?plain=1

Some notes:

  • http://shiffman.net/a2z/ is not working anymore, so I replaced it with the A2Z GitHub org instead
  • I linked the source code from the archived website. It is however not working, the Wordnik words search API endpoint has been deprecated.
    CleanShot 2024-07-20 at 11 34 53@2x

TODO

  • Add thumbnail image
  • Finalize the updated sketch using Datamuse (?)
  • Update video description on YouTube to fix missing chapters and dead links?

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for codingtrain ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 134ff4c
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/66d0e6f3bc5e4000081e4615
😎 Deploy Preview https://deploy-preview-1671--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fturmel fturmel added the challenge Creating challenge page label Jul 20, 2024
@dipamsen
Copy link
Member

dipamsen commented Jul 20, 2024

Code example can be linked from https://github.com/CodingTrain/Coding-Challenges instead of the archived repo

@fturmel
Copy link
Collaborator Author

fturmel commented Jul 21, 2024

Code example can be linked from https://github.com/CodingTrain/Coding-Challenges instead of the archived repo

Thanks, much better (although still a broken example because of the Wordnik change, but there's not much we can do about this...).

@shiffman
Copy link
Member

FYI the shiffman.net website is archived here! https://shiffman-archive.netlify.app/a2z/

I'm not maintaining it so I moved it off of shiffman.net (which now forwards to thecodingtrain.com) but I'm happy to link to any old but still useful material.

I prefer to recreate the code examples from the videos as p5 web editor examples (if they don't require node.js). I have some working wordnik examples as part of my last fall class's materials: https://editor.p5js.org/a2zitp/collections/cgfJWhpsE Maybe I could update the code?

@kfahn22
Copy link
Collaborator

kfahn22 commented Jul 24, 2024

Since v4 has been deprecated (at least until v5 is released), I think we will need to substitute a different API. (The code examples from the fall no longer return results.). ChatGPT suggested Datamuse as a substitute. Here is a sketch using it, although the code is slightly different -- the return options are more limited. The sketch creates the index.jpg file so if used the extra css will need to be edited. If this is OK I can edit it and create a code example.

https://editor.p5js.org/kfahn/sketches/1-UXfIl9b

index

@fturmel
Copy link
Collaborator Author

fturmel commented Jul 28, 2024

FYI the shiffman.net website is archived here! https://shiffman-archive.netlify.app/a2z/

I'm not maintaining it so I moved it off of shiffman.net (which now forwards to thecodingtrain.com) but I'm happy to link to any old but still useful material.

Makes sense, I'll link there instead. I also opened a PR to fix the quick links in the archive shiffman/shiffman.net#136

I prefer to recreate the code examples from the videos as p5 web editor examples (if they don't require node.js). I have some working wordnik examples as part of my last fall class's materials: https://editor.p5js.org/a2zitp/collections/cgfJWhpsE Maybe I could update the code?

These still work (are you OK leaking all these API keys though...?). It's only the word search API endpoint used in the "acrostic" challenge that seems to have been shut down (they say "deprecated" in their message, but it stopped returning data altogether).
https://github.com/CodingTrain/Coding-Challenges/blob/main/073_Acrostic/P5/sketch.js#L8

@kfahn22 That's awesome, thanks! Datamuse seems like a good substitute for this. I'll link to your sketch directly for now, but let me know if the link changes if we move it to the Coding Train user, etc. Feel free to make the changes to the PR directly too if that's easier.

@shiffman
Copy link
Member

Responses to some notes above and I'm good to merge this when ready!

  1. The YT Description has been updated. I'll run the description generator again when this is finalized in order for any last updates. This is a good excuse for me to test Auto update YT Descriptions using the YouTube API #1621 by @dipamsen.
  2. When I put API keys in my examples I make sure they are "dummy" keys that I don't mind being shut off and I also try (I could do better) to talk about the risks and considerations of putting API keys in code. So, I guess that's a long answer to yes, I don't mind leaving the API keys in.

I removed the CSS styles, added a thank you to @kfahn22 in the comments, and saved it under the CT account:

https://editor.p5js.org/codingtrain/sketches/48yinqNpT

@shiffman shiffman marked this pull request as ready for review August 27, 2024 20:21
@shiffman shiffman marked this pull request as draft August 27, 2024 20:21
@kfahn22 kfahn22 marked this pull request as ready for review August 29, 2024 21:57
@shiffman
Copy link
Member

shiffman commented Sep 2, 2024

Going to merge this and then test #1621, thanks everyone for the efforts to getting this challenge added to the site! It's not a terribly popular one but I'll be doing it with my students this week so having the page of resources will be so helpful!

@shiffman shiffman merged commit 95040f5 into CodingTrain:main Sep 2, 2024
5 checks passed
@fturmel fturmel deleted the PR/challenge-73 branch September 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge Creating challenge page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants