⬆️ Upgrade to ESLint 5.1.0 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated experimentalObjectRestSpread flag in favor of ecmaVersion 2018 - Disable new `max-classes-per-file` rule - Disable new `max-lines-per-function` rule - Enable new `prefer-object-spread` rule as a warning
randycoulman
force-pushed
the
chores/eslint-5
branch
from
63e33dc
to
31d931d
Compare
🔥 Remove deprecated `no-catch-shadow` rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is based off of #105, so that PR needs to be merged first.
experimentalObjectRestSpreadflag in favor ofecmaVersion2018max-classes-per-filerulemax-lines-per-functionruleprefer-object-spreadrule as a warningno-catch-shadowruleThis upgrade was done as a separate PR since it involves a major version upgrade of eslint itself. We may want to mark this as a major version upgrade, though the upstream changes don't seem that significant. We may, however, want to release a version without this PR and then another version with it.
Closes #100