Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all dependencies #94

Merged
merged 8 commits into from
Feb 26, 2018
Merged

Upgrade all dependencies #94

merged 8 commits into from
Feb 26, 2018

Conversation

randycoulman
Copy link
Contributor

Add configuration for newly-defined rules. Most of them were straight-forward, with two exceptions I want to highlight:

  • I am uncertain about jest/consistent-test-it, but I believe we've standardized on always using test over it.
  • I am also uncertain about jest/lowercase-name, but I think it makes sense to make it a warning.

Thoughts?

Closes #85
Closes #86
Closes #87
Closes #88
Closes #89
Closes #90

- Add configuration for new rules
- Add configuration for new rules
- Add configuration for new rules
- I am uncertain about `jest/consistent-test-it`, but I believe we've standardized on always using `test` over `it`
- I am also uncertain about `jest/lowercase-name`, but I think it makes sense to make it a warning.
Copy link
Contributor

@frank-west-iii frank-west-iii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe both of those are perfectly reasonable based on my preferences as well.

@randycoulman randycoulman merged commit d164bad into master Feb 26, 2018
@randycoulman randycoulman deleted the chores/upgrades branch February 26, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants