Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve InputType for controls #75

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Shinigami92
Copy link
Contributor

No description provided.

@kasperpeulen
Copy link
Contributor

Thanks! @shilman Do you know if this is correct?

cc @kylegach

@shilman
Copy link
Contributor

shilman commented Feb 2, 2024

@kasperpeulen Will check! 👀

@Shinigami92
Copy link
Contributor Author

One week later, whats the state?

@Shinigami92
Copy link
Contributor Author

Can I help here? Why is this still blocked from merging? Looks like someone needs to make a review approval 🤔

@kasperpeulen
Copy link
Contributor

It looks good to me. @tmeasday @shilman maybe you can double-check

Copy link
Contributor

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @Shinigami92 for the contribution and for your patience getting it merged! The change is good and I tightened up the types with a discriminated union.

@shilman shilman changed the title Improve InputType Improve InputType for controls Mar 14, 2024
@shilman shilman merged commit c372cc8 into ComponentDriven:next Mar 14, 2024
@Shinigami92 Shinigami92 deleted the improve-input-type branch March 14, 2024 10:07
@Shinigami92
Copy link
Contributor Author

@shilman looks like the formatting is broken and also the release failed. Could you please fix this so the release can run?

@shilman
Copy link
Contributor

shilman commented Mar 14, 2024

Argh. Will get it fixed. Thanks!

@shilman shilman mentioned this pull request Mar 16, 2024
@Shinigami92
Copy link
Contributor Author

The types are released in 0.1.3-next.0 and I tried to test them out. Sadly I found out that we depend on @storybook/types that are currently on 8.0.0 and the csf types are just taken from there. So we still need to wait ...

@shilman
Copy link
Contributor

shilman commented Mar 18, 2024

🚀 PR was released in v0.1.3 🚀

@kasperpeulen
Copy link
Contributor

@Shinigami92 Will try to get this new version into 8.0.1

@Shinigami92
Copy link
Contributor Author

When will this be available in Storybook? Or do I do something wrong?
When I hove over the types in Storybook v8.0.5, nothing changed so far 🤔

A typed InputArg prop
image

The still not typed props like table
image


How the definitions are looking
image

@kasperpeulen
Copy link
Contributor

@Shinigami92 Working on releasing it, but first I have loosened the type a bit here:
#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants