Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs site dependency #473

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Fix docs site dependency #473

merged 2 commits into from
Sep 25, 2024

Conversation

fviolette
Copy link
Collaborator

Description

Add missing peer dependency leading to site build error:

[3/4] 🔗 Linking dependencies...
warning "astro > zod-to-ts@1.2.0" has unmet peer dependency "typescript@^4.9.4 || ^5.0.2".
warning Workspaces can only be enabled in private projects.
[4/4] 🔨 Building fresh packages...
success Saved lockfile.
✨ Done in 13.48s.
❯ yarn build
yarn run v1.22.22
warning package.json: No license field
$ cp ../CHANGELOG.md src/content/docs/changelog.md && astro build
Cannot find package 'typescript' imported from /Users/francois.violette/git/chproxy/docs/node_modules/zod-to-ts/dist/index.js
Stack trace:
at packageResolve (node:internal/modules/esm/resolve:839:9)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.resolve (node:internal/modules/esm/loader:523:25)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

@mga-chka
Copy link
Collaborator

@fviolette is it normal that https://chproxy-pr-473.onrender.com/ doesn't work if the PR is supposed to fix the doc?

@render render bot temporarily deployed to docs-add-missing-ts-peer-dep - chproxy PR #473 September 24, 2024 21:07 Destroyed
@fviolette
Copy link
Collaborator Author

fviolette commented Sep 24, 2024

The initial commit fixed it only locally and had silenced the warning.
The preview is now available after bumping the site builder and moving the peer to a dev dependency.

@mga-chka mga-chka merged commit 806699e into master Sep 25, 2024
6 checks passed
@mga-chka mga-chka deleted the docs-add-missing-ts-peer-dep branch September 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants