Skip to content

Commit

Permalink
Merge pull request #5 from Coreoz/evol/upgrade-libraries
Browse files Browse the repository at this point in the history
upgrade libraries
  • Loading branch information
amanteaux committed Jan 18, 2024
2 parents 0f5ac26 + 1aa012b commit ad674ab
Show file tree
Hide file tree
Showing 12 changed files with 33 additions and 42 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@
/full_content_transformed.pptx
/.apt_generated/
/.factorypath

# IntelliJ
/.idea
*.iml
14 changes: 7 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<maven.compiler.target>1.8</maven.compiler.target>
<additionalparam>-Xdoclint:none</additionalparam>

<poi.version>3.17</poi.version>
<poi.version>5.2.5</poi.version>
</properties>

<profiles>
Expand Down Expand Up @@ -163,38 +163,38 @@
<dependency>
<groupId>net.coobird</groupId>
<artifactId>thumbnailator</artifactId>
<version>0.4.8</version>
<version>0.4.20</version>
</dependency>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.25</version>
<version>2.0.7</version>
</dependency>

<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.16.18</version>
<version>1.18.30</version>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.12</version>
<version>4.13.2</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<version>3.8.0</version>
<version>3.23.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.2.3</version>
<version>1.4.12</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
4 changes: 1 addition & 3 deletions src/main/java/com/coreoz/ppt/PptHidingMapper.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,5 @@

@Value(staticConstructor = "of")
class PptHidingMapper {

private final Predicate<String> shouldHide;

Predicate<String> shouldHide;
}
12 changes: 5 additions & 7 deletions src/main/java/com/coreoz/ppt/PptImageMapper.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,12 @@

@Value(staticConstructor = "of")
class PptImageMapper {

public static final float DEFAULT_QUALITY_FACTOR = 1F;
public static final double DEFAULT_QUALITY_MULTIPLICATOR = 2.0;

private final PictureType targetFormat;
private final PptImageReplacementMode replacementMode;
private final byte[] value;
private final float qualityFactory;
private final double qualityMultiplicator;

PictureType targetFormat;
PptImageReplacementMode replacementMode;
byte[] value;
float qualityFactory;
double qualityMultiplicator;
}
2 changes: 1 addition & 1 deletion src/main/java/com/coreoz/ppt/PptImageReplacementMode.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ byte[] resize(byte[] imageData, String targetFormat, int width, int height,
}

@FunctionalInterface
private static interface ResizeFunction {
private interface ResizeFunction {
byte[] resizeImage(
byte[] imageData,
String targetFormat,
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/coreoz/ppt/PptParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ private static State process(State before, char c) {
}

@AllArgsConstructor
private static enum State {
private enum State {
INITIAL(false),
MAY_BE_VARIABLE(true),
START_VARIABLE(true),
Expand All @@ -180,7 +180,7 @@ private static enum State {
END_VARIABLE(false)
;

private boolean inVariable;
private final boolean inVariable;
}

}
4 changes: 1 addition & 3 deletions src/main/java/com/coreoz/ppt/PptStyleShapeMapper.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,5 @@

@Value(staticConstructor = "of")
class PptStyleShapeMapper {

private final BiConsumer<String, XSLFSimpleShape> applyStyle;

BiConsumer<String, XSLFSimpleShape> applyStyle;
}
9 changes: 3 additions & 6 deletions src/main/java/com/coreoz/ppt/PptStyleTextMapper.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
package com.coreoz.ppt;

import java.util.function.BiConsumer;

import lombok.Value;
import org.apache.poi.sl.usermodel.TextRun;

import lombok.Value;
import java.util.function.BiConsumer;

@Value(staticConstructor = "of")
class PptStyleTextMapper {

private final BiConsumer<String, TextRun> applyStyle;

BiConsumer<String, TextRun> applyStyle;
}
8 changes: 4 additions & 4 deletions src/main/java/com/coreoz/ppt/PptTemplates.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
import java.util.Optional;
import java.util.function.Consumer;

import org.apache.poi.POIXMLDocumentPart;
import org.apache.poi.POIXMLDocumentPart.RelationPart;
import org.apache.poi.PptPoiBridge;
import org.apache.poi.ooxml.POIXMLDocumentPart;
import org.apache.poi.ooxml.POIXMLDocumentPart.RelationPart;
import org.apache.poi.ooxml.PptPoiBridge;
import org.apache.poi.common.usermodel.HyperlinkType;
import org.apache.poi.sl.usermodel.Hyperlink;
import org.apache.poi.sl.usermodel.ShapeContainer;
Expand Down Expand Up @@ -357,7 +357,7 @@ private static Optional<PptVariable> parseHyperlinkVariable(XSLFSimpleShape simp


private static Optional<PptVariable> parseHyperlinkVariale(Hyperlink<?, ?> link) {
if(link != null && link.getTypeEnum() == HyperlinkType.URL) {
if(link != null && link.getType() == HyperlinkType.URL) {
return PptParser.parse(link.getAddress());
}
return Optional.empty();
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/com/coreoz/ppt/PptTextMapper.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

@Value(staticConstructor = "of")
class PptTextMapper {

private final Object value;
private final Function<String, Object> argumentToValue;

Object value;
Function<String, Object> argumentToValue;
}
6 changes: 2 additions & 4 deletions src/main/java/com/coreoz/ppt/PptVariable.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

@Value(staticConstructor = "of")
class PptVariable {

private final String name;
private final String arg1;

String name;
String arg1;
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.apache.poi;
package org.apache.poi.ooxml;

import org.apache.poi.xslf.usermodel.XSLFTextRun;
import org.apache.xmlbeans.XmlObject;
Expand Down

0 comments on commit ad674ab

Please sign in to comment.