Add gov proposal simulations #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 59.95% 59.72% -0.23%
==========================================
Files 54 54
Lines 7406 7434 +28
==========================================
Hits 4440 4440
- Misses 2641 2669 +28
Partials 325 325
|
pinosu
force-pushed
the
1063-gov_proposal_sim
branch
from
8faacec
to
9a785e8
Compare
pinosu
force-pushed
the
1063-gov_proposal_sim
branch
from
1310833
to
56b3faa
Compare
alpe
approved these changes
Dec 8, 2022
| // Simulate pin contract proposal | ||
| func SimulatePinContractProposal(wasmKeeper WasmKeeper, codeSelector CodeIDSelector) simtypes.ContentSimulatorFn { | ||
| return func(r *rand.Rand, ctx sdk.Context, accs []simtypes.Account) simtypes.Content { | ||
| codeID := codeSelector(ctx, wasmKeeper) |
There was a problem hiding this comment.
👍 I checked the doc and the execution is idempotent so it does not really matter if it was pinned before
| simtypes.RandStringOfLength(r, 10), | ||
| simtypes.RandStringOfLength(r, 10), | ||
| []types.AccessConfigUpdate{configUpdate}, | ||
| ) |
x/wasm/types/proposal.go
Outdated
| func NewUpdateInstantiateConfigProposal( | ||
| title string, | ||
| description string, | ||
| accessConfigUpdates []AccessConfigUpdate, |
There was a problem hiding this comment.
personal preference:
Suggested change
| accessConfigUpdates []AccessConfigUpdate, | |
| accessConfigUpdates ...AccessConfigUpdate, |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1063
Add gov proposal simulations: