Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OnRecvPacket method to panic when an error is returned by the VM (backport #1298) #1303

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 29, 2023

This is an automatic backport of pull request #1298 done by Mergify.
Cherry-pick of 5edfd6c has failed:

On branch mergify/bp/releases/v0.3x/pr-1298
Your branch is up to date with 'origin/releases/v0.3x'.

You are currently cherry-picking commit 5edfd6c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/wasm/keeper/relay_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/wasm/keeper/relay.go
	both modified:   x/wasm/relay_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

by the VM

(cherry picked from commit 5edfd6c)

# Conflicts:
#	x/wasm/keeper/relay.go
#	x/wasm/relay_test.go
@mergify mergify bot requested a review from alpe as a code owner March 29, 2023 11:16
@mergify mergify bot added the conflicts label Mar 29, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analizer.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found 17 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #1303 (8f1584c) into releases/v0.3x (d48bb69) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           releases/v0.3x    #1303      +/-   ##
==================================================
- Coverage           57.49%   57.46%   -0.03%     
==================================================
  Files                  55       55              
  Lines                7460     7460              
==================================================
- Hits                 4289     4287       -2     
- Misses               2865     2866       +1     
- Partials              306      307       +1     
Impacted Files Coverage Δ
x/wasm/keeper/relay.go 96.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

@pinosu pinosu merged commit ec264ae into releases/v0.3x Apr 4, 2023
@mergify mergify bot deleted the mergify/bp/releases/v0.3x/pr-1298 branch April 4, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant