Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trace param in system tests #1481

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Remove trace param in system tests #1481

merged 1 commit into from
Jul 4, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 4, 2023

Testing system tests without --trace param on node start
This resolves the issues with failing tests. Thanks to @julienrbrt for digging into this and the help! 🤗

@alpe alpe added the spike Demo to showcase an idea. label Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1481 (5c6b2fb) into main (255ba09) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
+ Coverage   57.75%   57.77%   +0.02%     
==========================================
  Files          63       63              
  Lines        8327     8327              
==========================================
+ Hits         4809     4811       +2     
+ Misses       3113     3112       -1     
+ Partials      405      404       -1     

see 1 file with indirect coverage changes

@alpe alpe removed the spike Demo to showcase an idea. label Jul 4, 2023
@alpe alpe changed the title [do not merge] Remove trace param in system tests Remove trace param in system tests Jul 4, 2023
@alpe alpe requested a review from pinosu July 4, 2023 11:10
@alpe alpe marked this pull request as ready for review July 4, 2023 11:10
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 👏

@alpe alpe merged commit c158b77 into main Jul 4, 2023
8 checks passed
@alpe alpe deleted the system_notrace branch July 4, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants