Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autopin gov contracts #726

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Autopin gov contracts #726

merged 3 commits into from
Jan 21, 2022

Conversation

ethanfrey
Copy link
Member

Closes #702

Simply calls pin after creation if we create it via a gov proposal

@ethanfrey ethanfrey requested a review from alpe as a code owner January 20, 2022 20:08
@ethanfrey ethanfrey added this to the v0.22 milestone Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #726 (231f2c8) into master (4bf0092) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 231f2c8 differs from pull request most recent head e9d96cf. Consider uploading reports for the commit e9d96cf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   59.92%   59.90%   -0.03%     
==========================================
  Files          49       49              
  Lines        5602     5604       +2     
==========================================
  Hits         3357     3357              
- Misses       2002     2003       +1     
- Partials      243      244       +1     
Impacted Files Coverage Δ
x/wasm/keeper/proposal_handler.go 61.90% <50.00%> (-1.21%) ⬇️

@ethanfrey
Copy link
Member Author

@alpe This should be fine. I just don't cover the case of PinCode returning an error, thus the patch cover issue

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ethanfrey
Copy link
Member Author

Changelog entry added. This should also be ready to merge (merge conflicts on CHANGELOG with #727 but we can just keep both lines)

@ethanfrey ethanfrey merged commit b4258b9 into master Jan 21, 2022
@ethanfrey ethanfrey deleted the 702-autopin-gov-contracts branch January 21, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-pin code when uploaded by governance
2 participants