Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding client concerns #34

Merged
merged 37 commits into from
Jul 5, 2024
Merged

Adding client concerns #34

merged 37 commits into from
Jul 5, 2024

Conversation

einari
Copy link
Contributor

@einari einari commented Jul 1, 2024

Added

  • Adding support for ignoring validation in the Command and Query pipelines by adding a new attribute in front of either a controller class or an action method. [IgnoreValidation].
  • Adding support for applying paging from the client without having to implement paging in the backend by supporting well-known query types such as IQueryable. By returning a queryable in the Query controller action, it will add .Skip().Take() statements correctly.

Fixed

  • Fixes a bug in the proxy generator where it treated query arguments that were concept types as complex types and flattened them to be called value. Obviously not the correct expected name, and could cause conflicts when having multiple arguments.

@einari einari added the minor label Jul 1, 2024
@einari einari changed the title Minor-fixes Adding client concerns Jul 1, 2024
@woksin
Copy link
Contributor

woksin commented Jul 5, 2024

I fixed the issue with paging, it was due to the handling of state using useState that screwed up a lot of the things. I made the useQuery code a lot simpler and had to remove the private _ fields from the QueryFor type because it caused problems due to React's useState shallow copying

@woksin
Copy link
Contributor

woksin commented Jul 5, 2024

Sorting is not working at all, so I just skipped that for now as I have no idea how to fix it

@woksin woksin merged commit 7b50867 into main Jul 5, 2024
8 checks passed
@woksin woksin deleted the minor-fixes branch July 5, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants