Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set init store to MVVM #43

Closed
wants to merge 3 commits into from

Conversation

maspasov
Copy link
Contributor

@maspasov maspasov commented Jul 19, 2024

Added

MVVM now has a prop for the init store. We can define global store and observe into every component for some changes in that store.
I fixed an error in the Identity provider in case of no valid response from that API.

Changed

  • MVVM Provider
  • Identity Provider

Fixed

image

Example how we can set init store from some App:

image

@einari einari added the minor label Jul 22, 2024
@einari
Copy link
Contributor

einari commented Jul 22, 2024

A couple of things:

  1. Could you fix the description to be more like we have for all of our releases. The pictures don't really explain what has been changed / added / fixed in the release. For inspiration, have a look here.
  2. Please set the correct labels for what type of semantic version change this represents.
    image
  3. Could you explain what this change does? Since we already have the Mobx options on the MVVMProps and initStoreis not a concept in application model itself, I'm struggling to see if the introduction of this property will affect anything?

@maspasov maspasov closed this Jul 22, 2024
@maspasov
Copy link
Contributor Author

A couple of things:

  1. Could you fix the description to be more like we have for all of our releases. The pictures don't really explain what has been changed / added / fixed in the release. For inspiration, have a look here.
  2. Please set the correct labels for what type of semantic version change this represents.
    image
  3. Could you explain what this change does? Since we already have the Mobx options on the MVVMProps and initStoreis not a concept in application model itself, I'm struggling to see if the introduction of this property will affect anything?

I have added initStore prop because it will be used for MVVM provider, mobx prop is a specific property for configuring Mobx library. There is a perfect example of what we can do with the store provider which is MVVM in our case. https://youtu.be/pnhIJA64ByY?t=261

@maspasov maspasov reopened this Jul 22, 2024
@maspasov
Copy link
Contributor Author

We decided not to add a store to the MVVM provider. So for now I will close that PR and add fix regarding IdentityProvider as a separate PR.

@maspasov maspasov closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants