Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on S3 scratch bucket #69

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Add documentation on S3 scratch bucket #69

merged 3 commits into from
Jul 21, 2023

Conversation

scottyhq
Copy link
Contributor

Addresses #68

@scottyhq scottyhq requested review from tsnow03 and jomey July 20, 2023 16:58
Copy link
Member

@tsnow03 tsnow03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 3 suggestions, but everything else looks great! Thanks Scott!

@jomey
Copy link

jomey commented Jul 20, 2023

Not sure if this is a requirement here, but should the notebook be committed as rendered? More of a curious question.

@jomey
Copy link

jomey commented Jul 20, 2023

Also along the lines of 'rendered version', would it be good to have this example not tailored to your GitHub username and use a generic one?
Mainly wondering if someone just wants to test this notebook and walks through the steps that this person might overwrite your personal bucket 😄

@scottyhq
Copy link
Contributor Author

Not sure if this is a requirement here, but should the notebook be committed as rendered? More of a curious question.

execute:
execute_notebooks: 'off'

Based on that setting the notebook must be rendered. Probably worth opening another issue to discuss simplifying github actions borrowed from the uw hackweeks.

@scottyhq
Copy link
Contributor Author

would it be good to have this example not tailored to your GitHub username and use a generic one?

Good point! I'll use octocat

@scottyhq
Copy link
Contributor Author

Thanks for the review @tsnow03 and @jomey I think this is ready to merge!

@scottyhq scottyhq merged commit 1e4720f into main Jul 21, 2023
2 checks passed
@scottyhq scottyhq deleted the scratch-bucket branch July 21, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants