Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: style code vertically and implement consts & vars #21

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

secretnamebasis
Copy link

@secretnamebasis secretnamebasis commented Jan 27, 2024

Description

Please include a summary of the changes and the related issue or feature.

I have included a .gitignore ; which, is self explanatory.

Additionally, I have included const.go, struct.go and var.go pages for greater clarity and long term maintenance of the code.

The point was to strip the sum < 1000 strings from the code for better management, eliminate duplication and ease of future multi language translations.

While some of the var/const names might not be to DEROFDN spec, every string was preserved for multi language translations.

Additionally, all code was styled vertically. This was done for great ease of access visually parsing code and ability to comment on a near line by line basis.

NOTE: The merge process is as follows:

  • Your pull request should be directed to dev branch.
  • When it will be merged in dev, we will compile and merge within dev and then push into main for final release.

Fixes # (issue)

Type of change

Please select the right one.

  • (Patch) Bug fix (non-breaking change which fixes an issue)
  • (Minor) New feature (non-breaking change which adds functionality)
  • (Major) Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Which part is impacted ?

  • UI/UX
  • Dashboard
  • History
  • Send
  • Module: Identity
  • Module: My Account
  • Module: Messages
  • Module: Transfers
  • Module: Asset Explorer
  • Module: Services
  • Module: Cyberdeck
  • Module: Datapad
  • Misc (documentation, etc...)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code (if applicable)
  • My changes generate no new warnings
  • I have updated the semver version (if applicable)

License

I am contributing & releasing the code under RESEARCH LICENSE (which can be found here).

@secretnamebasis secretnamebasis changed the title major: style code vertically and implement consts & vars minor: style code vertically and implement consts & vars Jan 27, 2024
secretnamebasis and others added 2 commits February 3, 2024 04:58
commit 41e588b
Merge: 2eafb31 8f12159
Author: Dank <44716232+DankFC@users.noreply.github.com>
Date:   Fri Feb 2 22:03:29 2024 -0800

    Merge pull request DEROFDN#22 from DEROFDN/dev

    [BUG] Error in SC function execution

commit 8f12159
Author: Dank <44716232+DankFC@users.noreply.github.com>
Date:   Fri Feb 2 22:01:09 2024 -0800

    [BUG] Error in SC function execution

    Fixed a bug when trying to send an asset and DERO amount in the same smart contract function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant