Fix Submission.can_see_detail erroring when user is not authenticated
#1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1423 +/- ##
=======================================
Coverage 37.92% 37.92%
=======================================
Files 198 198
Lines 11339 11339
=======================================
Hits 4300 4300
Misses 7039 7039
Continue to review full report at Codecov.
|
quantum5
approved these changes
Jun 3, 2020
outloudvi
pushed a commit
to SchOJ/site
that referenced
this pull request
Oct 27, 2020
malbareda
pushed a commit
to malbareda/JOEL-web
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an issue for the current uses of
Submission.can_see_detailas all instances are guarded by some variation ofLoginRequiredMixin, but it's nice to have working code...This PR is required to allow the unittests in #1416 to pass (correctly).