Revert "Replace join text with spectate if user is finished contest; fixes #544" #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1473 +/- ##
=======================================
Coverage 45.85% 45.85%
=======================================
Files 208 208
Lines 11991 11991
=======================================
Hits 5498 5498
Misses 6493 6493 Continue to review full report at Codecov.
|
Carson-Tang
approved these changes
Jul 1, 2020
quantum5
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1272.
As stated in #544 (comment), the change from #1272 does not fix #544. In fact, this code is never true, since if
not request.in_contest, thencontest.is_in_contest(request.user)is false.Thus, we revert that commit to reduce dead code.