Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent users from voting on hidden comments #1503

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Prevent users from voting on hidden comments #1503

merged 1 commit into from
Aug 10, 2020

Conversation

zecookiez
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1503 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files         208      208           
  Lines       12024    12024           
=======================================
  Hits         5538     5538           
  Misses       6486     6486
Impacted Files Coverage Δ
judge/views/comment.py 40.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854a28a...9df86a2. Read the comment docs.

Ninjaclasher
Ninjaclasher approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@crackersamdjam
Copy link

orz zeyu

Xyene
Xyene approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Xyene Xyene merged commit e21e7a9 into DMOJ:master Aug 10, 2020
@zecookiez zecookiez deleted the hidden-comment-vote-fix branch August 10, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xyene Xyene Xyene approved these changes

@Ninjaclasher Ninjaclasher Ninjaclasher approved these changes

@Carson-Tang Carson-Tang Carson-Tang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zecookiez @codecov-commenter @crackersamdjam @Xyene @Ninjaclasher @Carson-Tang