Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blank assignees when editing ticket #1534

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

zecookiez
Copy link
Contributor

@zecookiez zecookiez commented Sep 13, 2020

Fixes #1529

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020

Codecov Report

Merging #1534 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1534      +/-   ##
==========================================
+ Coverage   46.05%   46.07%   +0.01%     
==========================================
  Files         209      210       +1     
  Lines       12059    12063       +4     
==========================================
+ Hits         5554     5558       +4     
  Misses       6505     6505              
Impacted Files Coverage Δ
judge/migrations/0111_blank_assignees_ticket.py 100.00% <100.00%> (ø)
judge/models/ticket.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5122c10...c15ceb8. Read the comment docs.

@fluix-dev
Copy link
Contributor

I think you have to generate a migration when you change this.

Copy link
Contributor

@fluix-dev fluix-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, edit your PR body to include Fixes #1529 so GitHub recognizes it.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiritofeng kiritofeng merged commit 3a819d4 into DMOJ:master Sep 28, 2020
@zecookiez zecookiez deleted the fix-blank-ticket-assignee branch September 28, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket admin should allow blank assignee
4 participants