Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_public to APIProblemDetail #1564

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Add is_public to APIProblemDetail #1564

merged 1 commit into from
Oct 17, 2020

Conversation

jtyliu
Copy link
Contributor

@jtyliu jtyliu commented Oct 9, 2020

Adds is_public to tell which problems are public, so you don't leak your private problems when using the api token

@codecov-io
Copy link

Codecov Report

Merging #1564 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
- Coverage   46.15%   45.57%   -0.59%     
==========================================
  Files         211      234      +23     
  Lines       12087    13038     +951     
==========================================
+ Hits         5579     5942     +363     
- Misses       6508     7096     +588     
Impacted Files Coverage Δ
judge/views/api/api_v2.py 49.01% <ø> (ø)
src/martor/martor/widgets.py 53.84% <0.00%> (ø)
src/martor/martor/models.py 57.14% <0.00%> (ø)
src/ansi2html/ansi2html/style.py 18.33% <0.00%> (ø)
...-wpadmin/wpadmin/templatetags/wpadmin_menu_tags.py 30.33% <0.00%> (ø)
src/dmoj-wpadmin/wpadmin/__init__.py 100.00% <0.00%> (ø)
src/django-sortedm2m/sortedm2m/fields.py 85.50% <0.00%> (ø)
src/martor/martor/views.py 38.23% <0.00%> (ø)
src/django-sortedm2m/sortedm2m/forms.py 25.35% <0.00%> (ø)
dmoj/local_settings.py 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d783f...b9258a2. Read the comment docs.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also submit a PR with the doc changes.

@jtyliu
Copy link
Contributor Author

jtyliu commented Oct 9, 2020

Available here.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xyene Xyene merged commit 57169bf into DMOJ:master Oct 17, 2020
outloudvi pushed a commit to SchOJ/site that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants