Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce time complexity for chain of * in problem filter #1658

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

quantum5
Copy link
Member

This has not been integration tested, but the snippets work.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #1658 (d7ab327) into master (c0dbc8c) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1658   +/-   ##
=======================================
  Coverage   46.24%   46.25%           
=======================================
  Files         215      215           
  Lines       12279    12282    +3     
=======================================
+ Hits         5679     5681    +2     
- Misses       6600     6601    +1     
Impacted Files Coverage Δ
judge/tasks/user.py 24.63% <50.00%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dbc8c...d7ab327. Read the comment docs.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it seems I didn't run into this because this exact issue was fixed in Python 3.9 (commit) and I was on Python 3.9 instead of Python 3.8. It might be good to add a comment saying this was fixed in Python 3.9, but we need the regex to be sure nothing bad happens for < 3.9.

@quantum5 quantum5 merged commit ac9cddd into master Apr 27, 2021
@quantum5 quantum5 deleted the crazy-fnmatch branch April 27, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants