Create initial revision on contest/problem clone #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
- Coverage 46.41% 46.39% -0.03%
==========================================
Files 216 216
Lines 12341 12351 +10
==========================================
+ Hits 5728 5730 +2
- Misses 6613 6621 +8
Continue to review full report at Codecov.
|
quantum5
approved these changes
May 8, 2021
kiritofeng
reviewed
May 8, 2021
| problem.contest = contest | ||
| problem.pk = None | ||
| ContestProblem.objects.bulk_create(contest_problems) | ||
| with transaction.atomic(), revisions.create_revision(): |
There was a problem hiding this comment.
Does revisions.create_revision(atomic=True) work?
There was a problem hiding this comment.
I checked the code and it does work, but I don't think it makes a difference which way you use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done to match the initial revision created when a contest/problem is create on the admin site.