Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store rounded participation score in database #1725

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

Ninjaclasher
Copy link
Member

Fixes #1595.

@codecov-commenter
Copy link

Codecov Report

Merging #1725 (cd422b0) into master (36ea904) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1725      +/-   ##
==========================================
+ Coverage   46.38%   46.43%   +0.04%     
==========================================
  Files         217      218       +1     
  Lines       12386    12416      +30     
==========================================
+ Hits         5745     5765      +20     
- Misses       6641     6651      +10     
Impacted Files Coverage Δ
judge/contest_format/atcoder.py 32.30% <0.00%> (ø)
judge/contest_format/ecoo.py 31.81% <0.00%> (ø)
judge/contest_format/icpc.py 29.72% <0.00%> (ø)
judge/contest_format/ioi.py 27.77% <0.00%> (ø)
judge/contest_format/legacy_ioi.py 37.03% <0.00%> (ø)
judge/views/two_factor.py 39.75% <ø> (+0.70%) ⬆️
judge/signals.py 64.19% <20.00%> (-2.91%) ⬇️
judge/admin/profile.py 62.22% <87.50%> (+1.98%) ⬆️
judge/contest_format/default.py 84.44% <100.00%> (ø)
judge/models/profile.py 90.90% <100.00%> (-0.71%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c363a38...cd422b0. Read the comment docs.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; only remaining question is if it's worth it to run this computation against all currently existing participations for consistency.

@quantum5 quantum5 merged commit 8ab68f4 into DMOJ:master Jun 17, 2021
@Ninjaclasher Ninjaclasher deleted the participation-rounded-score branch March 20, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float precision issue in contest ranking
4 participants