-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editorial column and filtering #1844
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1844 +/- ##
==========================================
- Coverage 46.09% 46.05% -0.05%
==========================================
Files 224 226 +2
Lines 12876 12933 +57
==========================================
+ Hits 5935 5956 +21
- Misses 6941 6977 +36
Continue to review full report at Codecov.
|
e37d7d9
to
978dbc5
Compare
978dbc5
to
5fa8230
Compare
Sorting was removed entirely. |
3f0a401
to
9bc73ff
Compare
The problem page now has an editorial column. The search form can now be used to only show problems with an editorial.
9bc73ff
to
7316268
Compare
@@ -151,6 +157,14 @@ ul.problem-list { | |||
color: orange; | |||
} | |||
|
|||
.has-editorial-color { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can avoid the extra class since you're already tagging with an attribute
.has-editorial-color { | |
td[editorial=1] i { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But w/e, the rest of the code is written like this already so sure
The problem page now has an editorial column. The search form can now be
used to only show problems with an editorial.
The only extraneous change is adding a method to
Problem
,has_public_editorial
.Here's some screenshots of the UI I get locally:
Editorial Column, plus sorting:
Filtering: