Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve submission status's i18n strings #1946

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented May 28, 2022

Old code:

<b>{{ _('Batch ') }}#{{ 1 }}</b>
<b>{{ _('Case') }} #{{ 2 }}:</b>
<b>{{ _('Pretest') }} #{{ 3 }}:</b>
<b>{{ _('Test case') }} #{{ 4 }}:</b>

New code (this should be better for i18n):

<b>{{ _('Batch #%(id)d', id=1) }}</b>
<b>{{ _('Case #%(id)d:', id=2) }}</b>
<b>{{ _('Pretest #%(id)d:', id=3) }}</b>
<b>{{ _('Test case #%(id)d:', id=4) }}</b>

@codecov-commenter
Copy link

Codecov Report

Merging #1946 (26d2993) into master (966b37d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1946   +/-   ##
=======================================
  Coverage   46.46%   46.46%           
=======================================
  Files         236      236           
  Lines       13114    13114           
=======================================
  Hits         6093     6093           
  Misses       7021     7021           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966b37d...26d2993. Read the comment docs.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 2cd60d7 into DMOJ:master Jul 18, 2022
@int-y1 int-y1 deleted the sub-status-i18n branch July 25, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants