Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm rejudging on submission page #2010

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Oct 12, 2022

If a contest sub is rejudged and the verdict doesn't change, did the organizer still mess up?

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 46.50% // Head: 46.50% // No change to project coverage 👍

Coverage data is based on head (59d72a1) compared to base (932cbf1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2010   +/-   ##
=======================================
  Coverage   46.50%   46.50%           
=======================================
  Files         236      236           
  Lines       13088    13088           
=======================================
  Hits         6086     6086           
  Misses       7002     7002           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Riolku Riolku force-pushed the confirm-rejudge branch 2 times, most recently from 8927f2c to c53ae01 Compare October 12, 2022 04:48
@@ -74,10 +74,19 @@
<div><a href="{{ url('problem_submit', submission.problem.code, submission.id) }}">{{ _('Resubmit') }}</a></div>
{% endif %}
{% if perms.judge.rejudge_submission and not submission.is_locked %}
{% compress js %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we shoving this into a separate js file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should it go? The JS blocks in this file are in unrelated if blocks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, seems fine, it'll get compressed.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit c4abddb into DMOJ:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants