-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm rejudging on submission page #2010
Conversation
cee7361
to
6b676d2
Compare
Codecov ReportBase: 46.50% // Head: 46.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2010 +/- ##
=======================================
Coverage 46.50% 46.50%
=======================================
Files 236 236
Lines 13088 13088
=======================================
Hits 6086 6086
Misses 7002 7002 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8927f2c
to
c53ae01
Compare
c53ae01
to
59d72a1
Compare
@@ -74,10 +74,19 @@ | |||
<div><a href="{{ url('problem_submit', submission.problem.code, submission.id) }}">{{ _('Resubmit') }}</a></div> | |||
{% endif %} | |||
{% if perms.judge.rejudge_submission and not submission.is_locked %} | |||
{% compress js %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we shoving this into a separate js file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should it go? The JS blocks in this file are in unrelated if blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, seems fine, it'll get compressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
If a contest sub is rejudged and the verdict doesn't change, did the organizer still mess up?