Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor buttons when replying to comment #2050

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Dec 10, 2022

i.e. change enough ids to make window.DjangoPagedown.createEditor happy

also, this js looks even more trash than before 🚮

fixes #1486

@codecov-commenter
Copy link

Codecov Report

Base: 46.44% // Head: 46.44% // No change to project coverage 👍

Coverage data is based on head (8cadc51) compared to base (8e914a0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2050   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files         236      236           
  Lines       13072    13072           
=======================================
  Hits         6071     6071           
  Misses       7001     7001           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️

@Xyene Xyene merged commit 97f2c45 into DMOJ:master Dec 10, 2022
@int-y1 int-y1 deleted the fix-reply-btn branch December 10, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown helpers don't work when replying to a comment.
3 participants