Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize labels in edit profile page #2073

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Standardize labels in edit profile page #2073

merged 1 commit into from
Jan 2, 2023

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Dec 19, 2022

  • time zone is preferred
  • Gravatar's link has a pointless title

@codecov-commenter
Copy link

Codecov Report

Base: 46.44% // Head: 46.44% // No change to project coverage 👍

Coverage data is based on head (1a293cd) compared to base (05a42d8).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2073   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files         236      236           
  Lines       13072    13072           
=======================================
  Hits         6071     6071           
  Misses       7001     7001

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Ninjaclasher
Ninjaclasher approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kiritofeng
kiritofeng approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xyene
Xyene approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 6c5dd7b into DMOJ:master Jan 2, 2023
@int-y1 int-y1 deleted the edit-prof-labels branch January 2, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xyene Xyene Xyene approved these changes

@kiritofeng kiritofeng kiritofeng approved these changes

@Ninjaclasher Ninjaclasher Ninjaclasher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@int-y1 @codecov-commenter @Xyene @kiritofeng @Ninjaclasher