[REFACTOR/#8] 코드리뷰 반영 포함 리팩터링

DO-SOPT-ANDROID · Dec 22, 2023 · a4ec4fd · a4ec4fd
1 parent 7b79087
commit a4ec4fd
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 11 deletions.
diff --git a/app/src/main/java/org/sopt/dosopttemplate/presentation/login/LoginActivity.kt b/app/src/main/java/org/sopt/dosopttemplate/presentation/login/LoginActivity.kt
@@ -88,7 +88,7 @@ class LoginActivity : AppCompatActivity() {
                     if (response.isSuccessful) {
                         val data: ResponseLoginDto = requireNotNull(response.body()!!)
                         val userId: Int = data.id
-                        toast("로그인 성공, 유저의 ID는 $userId 입니다")
+                        toast("로그인 성공")
                         val intent = Intent(this@LoginActivity, MainHomeActivity::class.java)
                         intent.putExtra("id", userId)
                         startActivity(intent)

diff --git a/app/src/main/java/org/sopt/dosopttemplate/presentation/mypage/MyPageFragment.kt b/app/src/main/java/org/sopt/dosopttemplate/presentation/mypage/MyPageFragment.kt
@@ -11,7 +11,7 @@ import org.sopt.dosopttemplate.databinding.FragmentMypageBinding
 
 class MyPageFragment : Fragment() {
     private var _binding: FragmentMypageBinding? = null
-    private val binding: FragmentMypageBinding get() = requireNotNull(_binding!!)
+    private val binding: FragmentMypageBinding get() = requireNotNull(_binding)
 
     override fun onCreateView(
         inflater: LayoutInflater,

diff --git a/app/src/main/java/org/sopt/dosopttemplate/presentation/signUp/SignUpActivity.kt b/app/src/main/java/org/sopt/dosopttemplate/presentation/signUp/SignUpActivity.kt
@@ -11,7 +11,6 @@ import org.sopt.dosopttemplate.module.ServicePool.authService
 import org.sopt.dosopttemplate.databinding.ActivitySignupBinding
 import org.sopt.dosopttemplate.presentation.login.LoginActivity
 import org.sopt.dosopttemplate.data.dto.request.RequestSignUpDto
-import org.sopt.dosopttemplate.data.dto.response.ResponseSignUpDto
 import org.sopt.dosopttemplate.utils.toast
 import retrofit2.Call
 import retrofit2.Response

diff --git a/app/src/main/res/drawable/shape_gray_fill_rect.xml b/app/src/main/res/drawable/shape_gray_fill_rect.xml
@@ -1,12 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">
-    <item>
-        <shape android:shape="rectangle">
-
-        </shape>
-    </item>
-
     <item
+
         android:bottom="2dp"
         android:left="2dp"
         android:right="2dp"

diff --git a/app/src/main/res/layout/item_follower.xml b/app/src/main/res/layout/item_follower.xml
@@ -32,13 +32,11 @@
         android:id="@+id/home_follower_tv_email"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
-        android:layout_marginEnd="264dp"
         android:layout_marginStart="20dp"
         android:maxLines="1"
         android:text="이메일:"
         android:textSize="13sp"
         app:layout_constraintBottom_toBottomOf="@id/home_follower_iv_profile"
-        app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toTopOf="@id/home_follower_iv_profile"
         app:layout_constraintStart_toEndOf="@id/home_follower_iv_profile"
         app:layout_constraintVertical_bias="1.0" />