Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration updated to highlight Orgunit and Person #8626

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

corrad82-4s
Copy link
Contributor

References

Add references/links to any related issues or PRs. These may include:

Description

This discovery configuration update enables search highlighting of OrgUnits and Person entities.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added this to the 7.5 milestone Jan 11, 2023
@tdonohue tdonohue added bug component: Discovery Related to Discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge. labels Jan 11, 2023
@tdonohue tdonohue self-requested a review January 11, 2023 22:05
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @corrad82-4s ! I tested this alongside DSpace/dspace-angular#1973 and verified that OrgUnit and Person entities now have hit highlights in their names in search results.

NOTE to others: This minor change to discovery.xml requires a full reindex to work properly (./dspace index-discovery -b)

@tdonohue tdonohue merged commit 6cdcfb5 into DSpace:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug component: Discovery Related to Discovery search or browse system
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants