Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTest unit testing #5

Closed
Aaron1178 opened this issue Jan 9, 2021 · 3 comments
Closed

PyTest unit testing #5

Aaron1178 opened this issue Jan 9, 2021 · 3 comments
Assignees
Labels
Milestone

Comments

@Aaron1178
Copy link
Member

No description provided.

@Aaron1178 Aaron1178 added this to the v1.0.0 milestone Jan 9, 2021
@Aaron1178 Aaron1178 self-assigned this Jan 9, 2021
@Aaron1178
Copy link
Member Author

Aaron1178 commented Jan 10, 2021

Starting my initial pytesting has raised a problem in Nif Explorers original code. The way Nif Explorer works at the moment is through class inheritance, which I cannot recall why I decided to code it like that. Instead, a better way to do it would be using objects:

explorer = NifExplorer()

Instead of using class inheritance like the following:

nif_explorer_base.nif_explorer(self)

That way, multiple objects of NifExplorer can be created and used, and proper class instantiation is used.

@Aaron1178
Copy link
Member Author

I had the objective of Test Driven Development in mind when re-designing Nif Explorer, as it was some simple PyTests that showed the old Nif Explorer was really bad and prone to a lot of bugs.

So now, with TDD the main focus, I am re-designing Nif Explorer, and thus far, has provided success in the re-design, thanks to TDD.

@Aaron1178
Copy link
Member Author

I will close this issue, as with the re-design of Nif Explorer, and the implementation of a testing framework, there is no reason to keep this issue open.

Aaron1178 added a commit that referenced this issue Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant