Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover soil/crop recipe ids from their respective itemstacks #227

Open
wants to merge 5 commits into
base: 1.16.5
Choose a base branch
from

Conversation

Quezler
Copy link

@Quezler Quezler commented May 18, 2022

The attempt mentioned i would be making in #226

  • If a valid soil id cannot be recovered from the data, only then will it try to get the soil from the respective itemstack
  • If a valid crop id cannot be recovered from the data, only then will it try to get the crop from the respective itemstack

It appears to be able to recover from (temporarily) deleted json files and (temporarily) renamed json files. (& recompiling)

The messages written to BotanyPots.LOGGER.error aren't yet updated to reflect that the crop "might not" be discarded because of the new recovery attempt, before I touch this further I'll first await feedback from the author. (does he like it?)

Quezler added a commit to Quezler/Enigmatica6 that referenced this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant