Fix wrong matching of lang attribute for embedded texttracks (#4047)

Dash-Industry-Forum · Sep 20, 2022 · 33c58ff · 33c58ff
1 parent 3d8ce30
commit 33c58ff
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/dash/DashAdapter.js b/src/dash/DashAdapter.js
@@ -38,6 +38,7 @@ import Event from './vo/Event';
 import FactoryMaker from '../core/FactoryMaker';
 import DashManifestModel from './models/DashManifestModel';
 import PatchManifestModel from './models/PatchManifestModel';
+import bcp47Normalize from 'bcp-47-normalize';
 
 /**
  * @module DashAdapter
@@ -1090,7 +1091,7 @@ function DashAdapter() {
         mediaInfo.codec = 'cea-608-in-SEI';
         mediaInfo.isEmbedded = true;
         mediaInfo.isFragmented = false;
-        mediaInfo.lang = lang;
+        mediaInfo.lang = bcp47Normalize(lang);
         mediaInfo.roles = ['caption'];
     }
 

diff --git a/src/dash/parser/matchers/LangMatcher.js b/src/dash/parser/matchers/LangMatcher.js
@@ -33,7 +33,7 @@
  */
 import BaseMatcher from './BaseMatcher';
 import DashConstants from '../../constants/DashConstants';
-var bcp47Normalize = require('bcp-47-normalize')
+import bcp47Normalize from 'bcp-47-normalize';
 
 class LangMatcher extends BaseMatcher {
     constructor() {

diff --git a/src/streaming/controllers/MediaController.js b/src/streaming/controllers/MediaController.js
@@ -33,7 +33,7 @@ import Events from '../../core/events/Events';
 import EventBus from '../../core/EventBus';
 import FactoryMaker from '../../core/FactoryMaker';
 import Debug from '../../core/Debug';
-var bcp47Normalize = require('bcp-47-normalize')
+import bcp47Normalize from 'bcp-47-normalize';
 import {extendedFilter} from 'bcp-47-match';
 
 function MediaController() {