Improve special character escaping in CMCD string values (#3866)

Dash-Industry-Forum · Jan 31, 2022 · a83535d · a83535d
1 parent 13a8c23
commit a83535d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/streaming/models/CmcdModel.js b/src/streaming/models/CmcdModel.js
@@ -512,8 +512,7 @@ function CmcdModel() {
             let cmcdString = keys.reduce((acc, key, index) => {
                 if (key === 'v' && cmcdData[key] === 1) return acc; // Version key should only be reported if it is != 1
                 if (typeof cmcdData[key] === 'string' && key !== 'ot' && key !== 'sf' && key !== 'st') {
-                    let string = cmcdData[key].replace(/"/g, '\"');
-                    acc += `${key}="${string}"`;
+                    acc += `${key}=${JSON.stringify(cmcdData[key])}`;
                 } else {
                     acc += `${key}=${cmcdData[key]}`;
                 }

diff --git a/test/unit/streaming.models.CmcdModel.js b/test/unit/streaming.models.CmcdModel.js
@@ -332,7 +332,7 @@ describe('CmcdModel', function () {
             expect(metrics.sf).to.equal('s');
         });
 
-        it('getHeaderParameters() returns CID in metrics if expicitly set', function () {
+        it('getHeaderParameters() returns CID in metrics if explicitly set', function () {
             const REQUEST_TYPE = HTTPRequest.MPD_TYPE;
             const MEDIA_TYPE = 'video';
             const CID = 'content_id';
@@ -623,7 +623,7 @@ describe('CmcdModel', function () {
             expect(metrics.sf).to.equal('s');
         });
 
-        it('getQueryParameter() returns CID in metrics if expicitly set', function () {
+        it('getQueryParameter() returns CID in metrics if explicitly set', function () {
             const REQUEST_TYPE = HTTPRequest.MPD_TYPE;
             const MEDIA_TYPE = 'video';
             const CID = 'content_id';