-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename classes with "Extensions" in name. #1022
Comments
Hello all. With 2.0 we have changed how you extend objects and the idea of marking a class with the name extension does not make much sense anymore. So I propose the following file name changes to happen before we release. Please take some time to review the changes and let me know ASAP if you have issue or suggestions with any of the changes. Very open minded to the name and location just want to get the extensions out of name and removed that folder. There a couple other moves to and from utils that seems to make sense to do now as well. streaming/extensions: streaming/utils: dash/extensions: dash ---> dash/util: protection: |
I think renaming SourceBufferExtensions to SourceBuffer could cause confusion - to make SourceBufferController makes more sense, as it creates and manipulates SourceBuffers. |
I think BaseURLLoader or BaseURLController are misleading. SegmentBaseLoader/Controller? |
I think both suggestions are good and I will use over my original names. Thanks guys. |
Fixed with PR #1145. |
We have moved away from the idea that you can only replace objects with the word Extensions in the file name.
VideoModelExtensions can be removed and method move do VideoModel.
The text was updated successfully, but these errors were encountered: