Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DroppedFramesRule.js for multiperiod does not works? #4040

Closed
1 task done
hakulat opened this issue Sep 9, 2022 · 0 comments · Fixed by #4048
Closed
1 task done

Fix DroppedFramesRule.js for multiperiod does not works? #4040

hakulat opened this issue Sep 9, 2022 · 0 comments · Fixed by #4048
Labels
Bug

Comments

@hakulat
Copy link

hakulat commented Sep 9, 2022 •
edited
Loading

Environment

no Steps to reproduce, found the issue by code view...

a66913f#diff-8130f7fb258a748cf8f02857b193683f1b61982fa0a0bd2a607c7148bc14a206
above ci, changes for src/streaming/rules/DroppedFramesHistory.js
lastDroppedFrames changed from number to object, but
intervalDroppedFrames = droppedVideoFrames(type number) - lastDroppedFrames(type object) not changed,
will cause intervalDroppedFrames = NaN, then DroppedFramesRule is ineffective
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing streamId to DroppedFramesHistory.js Dash-Industry-Forum/dash.js
1 participant
@hakulat