Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device pixel ratio to calculate size of portal for max representation size (with API) #1429

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

LloydW93
Copy link
Member

This supersedes PR #1030 by @nickygerritsen - resolving the conflicts and adding an API to control the feature.

…devicePixelRatio is taken into account which is defaulted to false.
@dsparacio
Copy link
Contributor

@LloydW93 Other than Dave's comment I think it LGTM

@LloydW93
Copy link
Member Author

LloydW93 commented Jun 1, 2016

Dave followed this up after the comment and pointed out that almost nowhere else today runs that check. I'm not saying I shouldn't fix it (I will), but it's a thing worth being aware of more generally.

@davemevans
Copy link
Contributor

davemevans commented Jun 2, 2016

I did follow up privately with @LloydW93. I was under the impression we checked more widely for window but, on looking at the codebase, this only happens in a couple of places. I'm inclined to merge this regardless of my comment as it LGTM too, and possibly open an issue to capture comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants