-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate settings matcher to work on each property individually #4018
separate settings matcher to work on each property individually #4018
Conversation
7920f7e
to
b513d27
Compare
@stschr Thank you for this, looks really good. Before I do the final code review: Did you already sign the feedback agreement: https://dashif.org/docs/DASH-IF-Feedback-Agreement-3-7-2014.pdf : If not can you please send the signed agreement to me to forward to DASH-IF. Thanks |
b513d27
to
4959923
Compare
51ab0cf
to
4c247c9
Compare
In addition to the two comments above: There is a reference to |
3bb7a49
to
3fbef1c
Compare
On I can work on the Up to you (@dsilhavy) to decide whether to close this PR now and file a new issue, or to keep this open an dwait for some more code on text. |
(text track selection will be considered later, and afterwards, this function can be removed again)
for now, keep both changes, although this can beatified
4224484
to
100f7dc
Compare
This change should fix both #3961 and also #3967
More intense testing or samples deemed beneficial.