-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt-core v1.0.0 #14
dbt-core v1.0.0 #14
Conversation
@ciklista Thank you for opening this PR (along with issues #12 and #13). Also, thank you for your detailed comment. At a quick first glance, I like the idea of making dbt-invoke backwards compatible and not having to require dbt-core>=1.0.0. Unfortunately, I am unavailable for the remainder of this week (I know, bad timing with the release of dbt 1.0.0) to actually complete the PR review, but I'll be back in action on Monday and plan on taking an in-depth look then. I hope that delay isn't too troublesome. Thanks again! |
@robastel No worries. I can run it with my local version for now. Looking forward to your review! |
I think there should be a quick addition on line 194 of the README to mention that dbt-invoke is now tested against dbt version 1.0: Line 194 in 8e54944
And update the version number here to '0.1.3' so that we can create a new release with your changes:
|
Co-authored-by: robastel <rob.astel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving! If this fails the linter then just pip install black
and run black dbt_invoke tests setup.py -S -l 79
from within the top level of the repo.
Looks like we have a dependency issue for the When I do
should we fix the python version for the tests as well? |
From a quick first investigation, the failure of the second test also seems to be related to python The test was failing for dbt The version of Here is the function that raises the error in |
Yeah I was looking into it too. dbt doesn't support Python 3.10 yet (https://docs.getdbt.com/faqs/all), so let's just test |
This PR should make
dbt-invoke
compatible with dbt-core v1.0.0.The main issue was the changed format of the
dbt run-operation
logs (#13).What has changed:
dbt run-operation
is now being called with the--log-format=json
global cli flag. This allows for easier parsing of the log output. (source)Backward compatibility
The code should be backward compatible with the two other dbt-core versions (0.18.x and 0.19.x) of this project. I've run the tests on all three dbt-core versions and they passed. This included parsing the
dbt run-opration
json log output accordingly as well as setting up two differentdbt_project.yml
for testing. I haven't done any additional testing as of now.I am still undecided whether that is the best solution or if a new release / tag of
dbt-invoke
should requiredbt-core>=1.0.0
and users should opt for older releases for olderdbt-core
versions. Any opinions on that?